Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User routed to different tab for external links #162

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

TheMohit2003
Copy link
Contributor

Copy link

vercel bot commented Jul 24, 2024

@TheMohit2003 is attempting to deploy a commit to the dottle's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@1ilit 1ilit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you also please add rel="noreferrer" to the anchors? Although not having this isn't in issue in modern browsers, it still throws an eslint error which makes the build fail.

@TheMohit2003
Copy link
Contributor Author

Done @1ilit , anything else ?

Copy link
Member

@1ilit 1ilit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thanks!

Copy link

vercel bot commented Jul 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drawdb ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 7:51am

@1ilit 1ilit merged commit 805fc70 into drawdb-io:main Jul 24, 2024
4 checks passed
@TheMohit2003 TheMohit2003 deleted the issueExternalLinks branch July 24, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants